fix(react-components): update model when geometry filter changed #4753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
Fix a bug where changing the geometryFilter input to the
CadModelContainer
would not update (remove/re-add) it correctly.How has this been tested? 🔍
In Storybook (and a double-check for unnecessary removes in FDX). In CadModelContainer.stories.tsx in react-components, replace the bottom part of
CadModelContainerStoryContent
with this:Then, when running the Storybook, the model should first appeared a little clipped, then whole, then clipped again.
Test instructions ℹ️
Checklist ☑️