Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-components): pick only relevant properties for inspect query #4748

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix(react-components): pick only relevant properties for inspect query #4748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c49004
fix(react-components): pick only relevant properties for inspect query
haakonflatval-cognite Sep 10, 2024
589894e
chore: fix a couple of other occurences
haakonflatval-cognite Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions react-components/src/query/use3dRelatedDirectConnections.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ export function use3dRelatedDirectConnections(
assert(instance !== undefined);
const views = await fdmSdk.inspectInstances({
inspectionOperations: { involvedViews: {} },
items: [{ instanceType: 'node', ...instance }]
items: [{ instanceType: 'node', externalId: instance.externalId, space: instance.space }]
});

const view = views.items[0].inspectionResults.involvedViews[0];
const instanceContent = (
await fdmSdk.getByExternalIds<Record<string, unknown>>(
[{ instanceType: 'node', ...instance }],
[{ instanceType: 'node', externalId: instance.externalId, space: instance.space }],
view
)
).items[0];
Expand All @@ -52,7 +52,11 @@ export function use3dRelatedDirectConnections(

const relatedObjectInspectionsResult = await fdmSdk.inspectInstances({
inspectionOperations: { involvedViews: {} },
items: directlyRelatedObjects.map((fdmId) => ({ ...fdmId, instanceType: 'node' }))
items: directlyRelatedObjects.map((fdmId) => ({
externalId: fdmId.externalId,
space: fdmId.space,
instanceType: 'node'
}))
});

const relatedObjectsViewLists = relatedObjectInspectionsResult.items.map(
Expand Down
6 changes: 5 additions & 1 deletion react-components/src/query/use3dRelatedEdgeConnections.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@ export function use3dRelatedEdgeConnections(

const views = await fdmSdk.inspectInstances({
inspectionOperations: { involvedViews: {} },
items: relatedInstances.map((instance) => ({ ...instance, instanceType: 'node' }))
items: relatedInstances.map((instance) => ({
externalId: instance.externalId,
space: instance.space,
instanceType: 'node'
}))
});

return zipWith(relatedInstances, views.items, (node, view) => ({
Expand Down
Loading