feat(react-components): Move global camera controls to Reveal context #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
haakonflatval-cognite
temporarily deployed
to
CI
GitHub Actions
Inactive
pramodcog
reviewed
Sep 9, 2024
pramodcog
reviewed
Sep 9, 2024
| return null; | ||
| }; | ||
|
|
||
| export const useReveal = (): Cognite3DViewer => { |
There was a problem hiding this comment.
This should be in hooks folder?
There was a problem hiding this comment.
I don't think so, the convention we have been using so far, is that hooks that are sort-of exposing values from a Context, are put together with that Context. That's how this hook was placed before this PR as well, in ViewerContext.ts
pramodcog
reviewed
Sep 9, 2024
| */ | ||
|
|
||
| import { type MutableRefObject, useEffect, useRef } from 'react'; | ||
| import { useReveal } from '../../..'; |
pramodcog
approved these changes
Sep 9, 2024
haakonflatval-cognite
temporarily deployed
to
CI
GitHub Actions
Inactive
haakonflatval-cognite
deleted the
hflatval/move-camera-control-to-reveal-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
This moves the global camera controls to props in RevealContext. Earlier, they would be given to a component that had been created from the
withCameraStateControl. This makes it very abritrary where in the code this camera control happens, and can be controlled from multiple places in the same page, which may cause unintended behavior. Now, the controls (a getter and setter) of the camera state are given as props directly to RevealContext, making it more obvious where this global state is controlled. Of course, the user may still mutate the state otherwise (either through the useNavigation hook, direct access to the Reveal camera manager, or just moving the camera with mouse or keyboard), and this will be handled gracefully by the RevealContext (the setter sent to RevealContext will be called in all these cases)How has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️