fix(react-components): Fixes bug where ground plane scale is stored as xz instead of xy #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
80
to
84
| // New scale format was introduced as a bug in the Scenebuilder | ||
| // on August 1st, 2024. This is a temporary fix to handle both formats. | ||
| // This should be removed when we upgrade the Scene Data Model to a new version | ||
| const groundPlaneUsesNewScaleFormat = groundPlaneUseNewScaleFormat( | ||
| scene.sceneConfiguration.updatedAt |
There was a problem hiding this comment.
Remember to write this down in your document, so that we remember to actually remove this 👍
| const scaleX = groundPlane.scaleX; | ||
| const scaleY = groundPlaneUsesNewScaleFormat ? groundPlane.scaleZ : groundPlane.scaleY; | ||
|
|
||
| const geometry = new PlaneGeometry(10000 * scaleX, 10000 * scaleY); |
There was a problem hiding this comment.
Still a bit weird to have this random scaling factor here 😅 Should it be in a variable?
There was a problem hiding this comment.
Agreed, fixed in 60db811
|
Title should be |
anders-hopland
changed the title
…ene-ground-plane-scale
anders-hopland
deleted the
amh/react-components-fix-bug-with-wrong-scene-ground-plane-scale
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description 📝
Fixes bug where starting August 1 2024, groundplanes in scene is stored with scale in XZ instead of XY. Checking
updatedAtto check which format ground plane scale has been written inHow has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️