Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): data model search for instance filter #4740

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

pramodcog
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4578

Description 📝

Data model search with filtering value were not consider for search result, this PR fixes the issue. And have also updated several query key which were missing

How has this been tested? 🔍

In Search

Test instructions ℹ️

  • In react-components, run yarn && yarn build && yalc publish
  • In fusion repo, load pramodcog/BND3D-4576 branch
  • Load Search application with cog-demo, select Browse 3D and expanded Search sidebar
  • Select Asset data model category and click on filter icon and select any tag

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodcog pramodcog added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Sep 6, 2024
@pramodcog pramodcog merged commit 3bbb849 into master Sep 6, 2024
23 checks passed
@pramodcog pramodcog deleted the pramodcog/BND3D-4578 branch September 6, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants