-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-components): remove all URL-mutations #4739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonflatval-cognite
had a problem deploying
to
CI
September 5, 2024 15:04
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
September 6, 2024 06:14
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
September 6, 2024 06:33
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
September 6, 2024 06:45
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
September 6, 2024 06:55
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
September 6, 2024 07:56
— with
GitHub Actions
Failure
danpriori
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I like the decision made to remove the URL params being controlled by react components and let the app drive this.
haakonflatval-cognite
temporarily deployed
to
CI
September 6, 2024 08:20
— with
GitHub Actions
Inactive
haakonflatval-cognite
added
the
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
label
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
Removes all URL-mutating functionality in react-components, so that we no longer change the URL for any reason within the library itself. I think this is good practice for a library in general, as the URL should be fully controlled by the application. In particular, this also solves a problem for FRS use in Canvas, which does not like the re-rendering that is caused by our URL-mutation.
This PR:
withCameraUrlState
to instead consume the setter and getter to manipulate the camera state, regardless of how it's backed by the applicationHow has this been tested? 🔍
Test instructions ℹ️
Link into fusion with this PR: https://github.com/cognitedata/fusion/pull/8047
Checklist ☑️