-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-components): Update fit view so it uses only visual object #4734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodcog
reviewed
Aug 29, 2024
@@ -237,11 +255,7 @@ export class RevealRenderTarget { | |||
// ================================================== | |||
|
|||
public fitView(): boolean { | |||
const boundingBox = this.clippedSceneBoundingBox; | |||
if (boundingBox.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that this check is not need any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the viewer is now like this (I have change it, and merged to master)
fitCameraToBoundingBox(boundingBox: THREE.Box3, duration?: number, radiusFactor: number = 2): void {
if (boundingBox.isEmpty()) {
return;
}
this._activeCameraManager.fitCameraToBoundingBox(boundingBox, duration, radiusFactor);
}
pramodcog
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description 📝
ToggleAllModelsVisibleCommand
. For time being only used for testing.RevealRenderTarget
, made several bounding box function for different usage, changed some naming. UpdatefitView
to only take the visual object in the scene.Range1/Range3
, addedmakeEmpty
function., That was missing. Fix empty box when copy()GroupTreeView
, added fix for infinite recursion. Renamed oldneedsUpdate()
toneedsUpdateCore()
AxisTreeView
andPlaneTreeView
, updated code to handle empty bounding boxes.FitModelsButton
, use the newfitCameraToSceneBoundingBox
in Reveal.useCameraNavigation.tsx
, addedfitCameraToVisualSceneBoundingBox
, to be used in fusionHow has this been tested? 🔍
In storybook/architecture:
Turn on axis
Toogle off all model visualization (Eye icon)
See that the axis is gone.
Try fix view (shouldn't do anything)
Toogle on all model visualization
See that the axis is coming back.
Try fix view
Try the same with a measurement box.
Checklist ☑️