Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): Move m/ft button to the domain object card #4731

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Aug 29, 2024

Type of change

Feat

Description 📝

See this conversation: https://cognitedata.slack.com/archives/G0115JQ8JM8/p1724831633376919

  • I also did some refactoring in the ObservationsDomainObject, because the Quantity was missing
  • Fix missing "Copy to clipboard" button.

How has this been tested? 🔍

Open storybook/architecture
Make a crop box or a measurement.

@nilscognite nilscognite marked this pull request as ready for review August 29, 2024 08:26
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a comment

Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nilscognite nilscognite enabled auto-merge (squash) August 29, 2024 11:22
@nilscognite nilscognite merged commit 5be4f0e into master Aug 29, 2024
14 checks passed
@nilscognite nilscognite deleted the np/move-mesurement.-button branch August 29, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants