Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-component): Tiny fix to visualize the point cloud filter in the settings drop down #4725

Merged
merged 3 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions react-components/src/architecture/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
export type { CommandUpdateDelegate } from './base/commands/BaseCommand';
export { BaseCommand } from './base/commands/BaseCommand';
export { BaseFilterCommand } from './base/commands/BaseFilterCommand';
export { BaseFilterItemCommand } from './base/commands/BaseFilterCommand';
export { BaseOptionCommand } from './base/commands/BaseOptionCommand';
export { BaseSliderCommand } from './base/commands/BaseSliderCommand';
export { BaseTool } from './base/commands/BaseTool';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,15 @@ import { KeyboardSpeedCommand } from '../../architecture/base/concreteCommands/K
import { ObservationsTool } from '../../architecture/concrete/observations/ObservationsTool';
import { createButtonFromCommandConstructor } from './CommandButtons';
import { SettingsCommand } from '../../architecture/base/concreteCommands/SettingsCommand';
import { PointCloudFilterCommand } from '../../architecture';

export class RevealButtons {
static Settings = (): ReactElement =>
createButtonFromCommandConstructor(() => new SettingsCommand());

static PointCloudFilter = (): ReactElement =>
createButtonFromCommandConstructor(() => new PointCloudFilterCommand());

static FitView = (): ReactElement =>
createButtonFromCommandConstructor(() => new FitViewCommand());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ function createOptionButton(command: BaseOptionCommand, t: TranslateDelegate): R
}

function createFilterButton(command: BaseFilterCommand, t: TranslateDelegate): ReactElement {
command.initializeChildrenIfNeeded();
if (!command.isVisible) {
return <></>;
}
Expand Down
Loading