Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-components): Smaller adjustment in clipping and measurement after meeting with user #4718

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix(react-components): Smaller adjustment in clipping and measurement after meeting with user #4718

merged 2 commits into from
Aug 22, 2024

Conversation

nilscognite
Copy link
Contributor

Type of change

Bug

Description 📝

This is based on feedback on a meeting today:

  • Increase selection radius for lines. Before it was hard to pick them.
  • Increate transparence of the clipping planes.
  • Change color of the clipping planes to be less saturated. Also switch the side colors.
  • When new plane is made, make sur that it is clipped in front of you.

@nilscognite nilscognite requested a review from a team as a code owner August 21, 2024 14:35
danpriori
danpriori approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilscognite nilscognite merged commit 5cbfa87 into master Aug 22, 2024
14 checks passed
@nilscognite nilscognite deleted the np/cropping-fixes-real branch August 22, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danpriori danpriori danpriori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilscognite @danpriori