Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (react-components): Export the base classes and some utility from the new architecture #4714

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

nilscognite
Copy link
Contributor

Type of change

Feat

Description 📝

  • 3D management need to use some of the basics in the architecture, so I exported all base classes and some of the utility classes/functions used by the actitecture.

  • Also updated the listeners for commands. The reason for this is that you can listen to if a tool is activated or deactivated.

Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 But I really want to revisit this at a later date to determine if there's some other way we can expose the functionality we want

@nilscognite nilscognite enabled auto-merge (squash) August 21, 2024 11:29
@nilscognite nilscognite merged commit c49c036 into master Aug 21, 2024
14 checks passed
@nilscognite nilscognite deleted the np/export branch August 21, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants