Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): Finalize the string for translation #4711

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Aug 20, 2024

For those strings that should not appear in production, the key is undefined.

Also, fix shortcut keys on commands so they are according to Cogs standard.

@nilscognite nilscognite requested a review from a team as a code owner August 20, 2024 11:54
@nilscognite nilscognite changed the title Finalize the string for translation fix(react-components): Finalize the string for translation Aug 20, 2024
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodcog pramodcog merged commit c03ffbe into master Aug 20, 2024
14 checks passed
@pramodcog pramodcog deleted the np/tooltip-string branch August 20, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants