-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-components): CoreDM queries #4708
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonflatval-cognite
had a problem deploying
to
CI
August 19, 2024 06:14
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
August 19, 2024 14:03
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
August 20, 2024 09:29
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
August 21, 2024 08:08
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
August 21, 2024 08:19
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
August 21, 2024 08:34
— with
GitHub Actions
Failure
haakonflatval-cognite
temporarily deployed
to
CI
August 21, 2024 08:45
— with
GitHub Actions
Inactive
haakonflatval-cognite
had a problem deploying
to
CI
August 22, 2024 09:02
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
August 22, 2024 09:08
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
August 22, 2024 10:12
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
August 22, 2024 12:19
— with
GitHub Actions
Failure
danpriori
reviewed
Sep 2, 2024
danpriori
reviewed
Sep 2, 2024
react-components/src/data-providers/core-dm-provider/CoreDm3dDataProvider.ts
Show resolved
Hide resolved
danpriori
reviewed
Sep 2, 2024
react-components/src/data-providers/core-dm-provider/cogniteAssetSourceWithProperties.ts
Outdated
Show resolved
Hide resolved
danpriori
reviewed
Sep 2, 2024
react-components/src/data-providers/core-dm-provider/cogniteCadNodeSourceWithProperties.ts
Outdated
Show resolved
Hide resolved
danpriori
reviewed
Sep 2, 2024
react-components/src/data-providers/core-dm-provider/cogniteCadRevisionSourceWithProperties.ts
Outdated
Show resolved
Hide resolved
danpriori
reviewed
Sep 2, 2024
react-components/src/data-providers/core-dm-provider/cogniteObject3dSourceWithProperties.ts
Outdated
Show resolved
Hide resolved
danpriori
reviewed
Sep 2, 2024
react-components/src/data-providers/core-dm-provider/filterNodesByMappedTo3d.ts
Show resolved
Hide resolved
danpriori
reviewed
Sep 2, 2024
react-components/src/data-providers/core-dm-provider/filterNodesByMappedTo3d.ts
Outdated
Show resolved
Hide resolved
danpriori
reviewed
Sep 2, 2024
react-components/src/data-providers/core-dm-provider/getCadConnectionsForRevisions.ts
Outdated
Show resolved
Hide resolved
danpriori
reviewed
Sep 2, 2024
react-components/src/data-providers/core-dm-provider/getCadConnectionsForRevisions.ts
Outdated
Show resolved
Hide resolved
danpriori
reviewed
Sep 2, 2024
react-components/src/data-providers/core-dm-provider/getCadModelsForInstance.ts
Outdated
Show resolved
Hide resolved
danpriori
reviewed
Sep 2, 2024
react-components/src/data-providers/core-dm-provider/getDMSRevision.ts
Outdated
Show resolved
Hide resolved
danpriori
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Some few comments (which doesnt block it) but the rest LGTM at least.
However, of course Anders or someone else that has experience with the CDM needs to have a look on this.
react-components/src/data-providers/core-dm-provider/cogniteCadNodeSourceWithProperties.ts
Show resolved
Hide resolved
react-components/src/data-providers/core-dm-provider/cogniteCadRevisionSourceWithProperties.ts
Outdated
Show resolved
Hide resolved
haakonflatval-cognite
temporarily deployed
to
CI
September 3, 2024 07:02
— with
GitHub Actions
Inactive
haakonflatval-cognite
temporarily deployed
to
CI
September 3, 2024 07:59
— with
GitHub Actions
Inactive
haakonflatval-cognite
temporarily deployed
to
CI
September 3, 2024 08:20
— with
GitHub Actions
Inactive
haakonflatval-cognite
temporarily deployed
to
CI
September 3, 2024 08:21
— with
GitHub Actions
Inactive
haakonflatval-cognite
temporarily deployed
to
CI
September 3, 2024 08:58
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/BND3D-4541
Description 📝
Now - this was originally just a PR to implement the CoreDM-part of the Fdm3dDataProvider. However, a few cascading effects occured, making this monstrosity of a PR. I'll go through the relevant changes:
FdmCadConnection
type no longer uses nodeIds, but treeIndex. This type is used as a common grounds for an "asset mapping" for the legacy FDM-API and the new CoreDM. Since CoreDM does not really have a concept of nodeId, I decided to change it totreeIndex
for future proofing. This may have performance implications for the legacy code, as I was forced to make another query translating between nodeIds and treeIndices. But all the better for CoreDM.I'll do my best to delegate the review across multiple team members
Remaining work:
Implement remaining functions (3-4 of them?)Have proper dataTest it allHow has this been tested? 🔍
In Fusion using this PR: https://github.com/cognitedata/fusion/pull/7854
Test instructions ℹ️
RevealContext
has theuseCoreDm
prop set totrue
Checklist ☑️