feat(react-components): fdm support in rule based core #4706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all relevant data for each instance - wip
…ctions to support fdm trigger type and styling - wip
…ssion to get time series
…oading and caching
haakonflatval-cognite
requested changes
Aug 21, 2024
react-components/src/components/RevealToolbar/RuleBasedOutputsButton.tsx
Outdated
Show resolved
Hide resolved
react-components/src/components/RuleBasedOutputs/RuleBasedOutputsSelector.tsx
Outdated
Show resolved
Hide resolved
react-components/src/query/useAll3dDirectConnectionsWithProperties.ts
Outdated
Show resolved
Hide resolved
react-components/src/query/useAll3dDirectConnectionsWithProperties.ts
Outdated
Show resolved
Hide resolved
…ttps://github.com/cognitedata/reveal into danpriori/BND3D-4440-fdm-support-in-rule-based-core
…0-fdm-support-in-rule-based-core
…ttps://github.com/cognitedata/reveal into danpriori/BND3D-4440-fdm-support-in-rule-based-core
haakonflatval-cognite
approved these changes
Aug 28, 2024
react-components/src/query/useAll3dDirectConnectionsWithProperties.ts
Outdated
Show resolved
Hide resolved
react-components/src/query/useAll3dDirectConnectionsWithProperties.ts
Outdated
Show resolved
Hide resolved
react-components/src/query/useAll3dDirectConnectionsWithProperties.ts
Outdated
Show resolved
Hide resolved
…ttps://github.com/cognitedata/reveal into danpriori/BND3D-4440-fdm-support-in-rule-based-core
danpriori
deleted the
danpriori/BND3D-4440-fdm-support-in-rule-based-core
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
Initial FDM support in Rule Based core.
For now it supports: regular string, numeric, datetime and boolean expressions.
How has this been tested? 🔍
It was tested by overwriting any ruleset created in the project with FDM rule object. The reason for that is to avoid breaking the Set Threholds in 3d Management and the Search UI with the new FDM rule set content which needs some new type definitions and logic. So the safest was to test locally overwriting the saved rules with FDM object content by hand.
Test instructions ℹ️
One way to test is to paste the content of a FDM rule object in the file:line RuleBasedOutputsButton.tsx:93 right after the const selectedRule. You can use the example in the file below (one rule works in cog-3d and another in cog-demo).
fdm-test2.json
Or this example with two rules in cog-demo and another one in cog-3d:
fmd-test3.json
Note: it works with the PR: https://github.com/cognitedata/fusion/pull/7676
Checklist ☑️