fix(react-components): Fix PointCloudFilterCommand because it didn't show up in Search #4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilscognite
changed the title
haakonflatval-cognite
approved these changes
Aug 19, 2024
Comment on lines
+97
to
+102
| for (const pointCloud of this.renderTarget.getPointClouds()) { | ||
| if (this._modelId === pointCloud.modelId && this._revisionId === pointCloud.revisionId) { | ||
| return pointCloud; | ||
| } | ||
| } | ||
| return undefined; |
There was a problem hiding this comment.
This function could be rewritten as return this.renderTarget.getPointClouds().find(pointCloud => pointCloud.modelId === this._modelId && pointCloud.revisionId === this._revisionId). It returns undefined if no applicable result is found
Comment on lines
+168
to
+173
| for (const pointCloud of this.renderTarget.getPointClouds()) { | ||
| if (this._modelId === pointCloud.modelId && this._revisionId === pointCloud.revisionId) { | ||
| return pointCloud; | ||
| } | ||
| } | ||
| return undefined; |
There was a problem hiding this comment.
This could also be written with find
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description 📝
I have changed the way to get the point cloud only. The new way is more secure for not having bugs.