Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): various small fixes and bump react-components to 0.55.4 #4702

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Fix a couple of small bugs in the code:

  • RevisionFdmNodeCache.ts: remove assert and instead ignore invalid values to make code more resilient (I've seen this assert trigger a couple of times in the wild)
  • Make sure mapped-equipment-query has undefined filter, if the incoming filter is empty
  • Don't send "asset ID Search" request if there are no assets. Saves a query which would have an empty response

How has this been tested? 🔍

In the Fusion UI

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Aug 13, 2024
@haakonflatval-cognite haakonflatval-cognite changed the title fix(react-components): various small fixes fix(react-components): various small fixes and bump react-components to 0.55.4 Aug 13, 2024
@haakonflatval-cognite haakonflatval-cognite merged commit 56959fc into master Aug 13, 2024
23 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/small-fixes branch August 13, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants