fix(react-components): Improve Scene home camera button and bump to 0.55.2 #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anders-hopland
commented
Aug 6, 2024
| return position | ||
| .clone() | ||
| .add(new Vector3(0, 0, -positionToSceneCenterDistance).applyQuaternion(rotation)); | ||
| return position.clone().add(new Vector3(0, 0, -50).applyQuaternion(rotation)); |
There was a problem hiding this comment.
Models are not neccesarily loaded, will thus often have the wrong bounding box. Using a constant for distance to target instead
greenbech
changed the title
greenbech
reviewed
Aug 6, 2024
| @@ -32,13 +32,42 @@ export const useSceneDefaultCamera = ( | |||
| }; | |||
| } | |||
|
|
|||
| const cameraNotSet = | |||
There was a problem hiding this comment.
Boolean values should be prefix with is, should or has in my opinion
There was a problem hiding this comment.
Usually, I would also prefer them to be positive. In this case, I would go for isCameraSet
anders-hopland
changed the title
anders-hopland
changed the title
anders-hopland
deleted the
amh/react-components-improve-scene-home-camera
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description 📝
Improves Scene home camera position.
How has this been tested? 🔍
Have built the package locally and tested it in Fusion
Test instructions ℹ️
Build locally and use in Fusion. Verify that Scene home camera is correct
Checklist ☑️