-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency @tweenjs/tween.js to v25 #4692
Conversation
There were failures in the visual tests workflow. |
There were failures in the visual tests workflow. |
There were failures in the visual tests workflow. |
b749486
to
618a603
Compare
There were failures in the visual tests workflow. |
618a603
to
38126e0
Compare
There were failures in the visual tests workflow. |
38126e0
to
780067e
Compare
There were failures in the visual tests workflow. |
780067e
to
54abb11
Compare
There were failures in the visual tests workflow. |
54abb11
to
182db51
Compare
There were failures in the visual tests workflow. |
Seems that Tween 24.0 no longer adds tweens to the global Tween group, and this group is deprecated. It means we now manually have to create and keep a Tween group within the Reveal instance, to which all subsequent tweens are added in order to be updated with the global timer. This will be extremely painful without dependency injection. I'll solve it by adding them into the deprecated group manually for now |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
^23.1.1
->^25.0.0
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
tweenjs/tween.js (@tweenjs/tween.js)
v25.0.0
: - end of the endCompare Source
BREAKING: no longer auto-start tweens by default when calling
tween.update()
. To restore previous behavior for the whole app, set the staticTween.autoStartOnUpdate
property totrue
.fix: make the
end()
method work better by setting the end time to start + duration instead of Infinity.Full Changelog: tweenjs/tween.js@v24.0.0...v25.0.0
v24.0.0
: - groupies!Compare Source
This release finally deprecates usage of
TWEEN
as a defaultGroup
. Allnew Tween
s now default to having no group, and must be explicitly added to a group if desired. Plus some other improvements to related to groups, including breaking changes (see below for all details and how to migrate if affected).What's Changed
New Contributors
More Details
feat: do not automatically add/remove a tween to/from its associated group, and do not automatically add
new Tween
s to the globalTWEEN
group by default.feat: the
tween.group(group)
method now has a reciprocaltween.remove()
method that will remove a tween from its associated group, and unassociate the group.tween.group()
without an arg is no longer valid, see breaking changes and migration below.fix: when a tween is stopped before its end time, do not allow its update method to continue, therefore preventing logic (f.e. repeat logic) from being triggered
docs: improved the docs, adding some missing information, removing all examples of the global
TWEEN
group which has been deprecated, and adding docs on how to manage groups of tweens. Also updated samples to useimport
syntax for importing Tween, avoiding the use of theTWEEN
UMD global variable which has been deprecated.feat: A new
Group.allStopped()
method returns true if all tweens in a group are not playing (i.e. stopped, and not paused), otherwise false. Useful for stopping an animation loop once all tweens in a group have finished their animation.deprecated: Methods on
TWEEN
that come fromGroup
are now deprecated to be removed in a future major version. Migrate forward by making anew Group
instead of usingTWEEN
as a group.deprecated: The UMD script that creates a global
TWEEN
variable is deprecated to be removed in a future major version.deprecated: The CommonJS build is deprecated to be removed in a future major version.
BREAKING:
start()
,stop()
, orpause()
, and thepreserve
parameter toGroup.update()
now defaults totrue
and is deprecated to be removed in a future major version.group.update()
withfalse
for the second parameter. To migrate forward, do not rely on automatic add/remove of tweens, and instead add/remove tweens to/from groups manually.Group.update()
no longer returns a boolean indicating if all tweens have been removed.Group.allStopped()
method to check if all tweens in a group are stopped in order to determine whether or not to continue an animation loop.group
parameter toTween.constructor
now defaults toundefined
instead of the globalTWEEN
group. Additionally it accepts a value oftrue
to restore the old default behavior. Thetrue
value is deprecated and will be removed in a future major version.true
to restore the old behavior. To migrate forward, usetween.group(group)
orgroup.add(tween)
instead.tween.group()
signature has been removed.group.add(tween)
orgroup.remove(tween)
instead.tween.group(TWEEN)
,TWEEN.add(tween)
, andTWEEN.remove(tween)
will also work for now, but they are deprecated and will be removed in a future major version.Group.update
's second parameterpreserve
defaults totrue
now, and is deprecated to be removed in a future major version, at which point tweens of a group will no longer be automatically added/remove to/from a group when calling any Tween methods such asstart()
,pause()
, orstop()
.false
to restore old default behavior when callinggroup.update()
. To migrate forward, do not rely on the automatic add/remove behavior, and instead manually add or remove tweens to or from groups.tween.update()
to be a no-op for stopped tweens, we had to break an undocumented feature that allowed tweens to move backward in time (https://github.com/tweenjs/tween.js/pull/271).tween.start(startTime)
then proceed to calltween.update(time)
in reverse order as before (see the unit test with "go backward in time" in its name). Without callingtween.start()
nothing will happen because stopped/completed tweens will now always return early fromupdate()
, as they are considered to be no longer running.Full Changelog: tweenjs/tween.js@v23.1.3...v24.0.0
v23.1.3
: - tisk tisk tiskCompare Source
Unfortunately we had to revert the fix for yoyo in v23.1.2 because it broke the yoyo demo. lol
So, this ironically fixes yoyo so that it is more fixed than how fixed we thought it was, and we will have to circle back to #677 again get yoyo even more fixed. 🥴
Full Changelog: tweenjs/tween.js@v23.1.2...v23.1.3
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.