Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): Add filter command and make mocks for the settings commands. #4688

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Aug 2, 2024

Type of change

Feat

Jira ticket 📘

No Jira ticket

Description 📝

  • Make mocks to simulate the different possibilities:

image

  • Add filter with optional color

image

Details:

  • Added virtual method getChildren. Used where it was possible.
  • New base class: BaseFilterCommand for handling filter
  • Some refactoring of the commands to make method names and some other names more homogeneous. And reuse getChildren() in the base classes. This eliminated some code around.
  • Made mock classes for various scenarios.
  • Made PointCloudFilterCommand for controlling the point filter.

Details on the React side

  • New component FilterButton and FilterItem.
  • The Filterbutton can be as a separate button or part of the settings. Same with the CommandButton.
  • The rest of the changes is made to get the code more homogeneous.
  • Fixed so the dropdown menus is closed when click outside. It was buggy before.
  • I have not done this for the settings dropdown. This is because we get the click outside event when the options or filtering is open and clicked. I have to investigate this further in another PR.

How has this been tested? 🔍

Go to Story book/Architecture
Click in the "Bug" icon for testing all settings
Click in "Filter" icons for test the stand alone filter.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@nilscognite nilscognite enabled auto-merge (squash) August 6, 2024 04:00
@nilscognite nilscognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Aug 6, 2024
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilscognite nilscognite merged commit 3871a35 into master Aug 6, 2024
14 checks passed
@nilscognite nilscognite deleted the np/point-cloud-filter-ui branch August 6, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants