feat(react-components): Add filter command and make mocks for the settings commands. #4688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
No Jira ticket
Description 📝
Details:
getChildren
. Used where it was possible.BaseFilterCommand
for handling filtergetChildren()
in the base classes. This eliminated some code around.PointCloudFilterCommand
for controlling the point filter.Details on the React side
Filterbutton
can be as a separate button or part of the settings. Same with theCommandButton
.How has this been tested? 🔍
Go to Story book/Architecture
Click in the "Bug" icon for testing all settings
Click in "Filter" icons for test the stand alone filter.
Checklist ☑️