feat(react-components): Preserve camera pivot point on Reset to Home #4686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodcog
reviewed
Jul 30, 2024
|
|
||
| // Keep the camera target (pivot) in the same position | ||
| viewer.cameraManager.setCameraState({ | ||
| target: initialCameraState.target |
There was a problem hiding this comment.
initialCameraState.target value be at origin when the scene is loaded for the first time, it would set the pivot point to origin when scene loaded for the first time
There was a problem hiding this comment.
Good point, that would be an issue if the models are really far away from origin
There was a problem hiding this comment.
Checking for camera being in origin in ea7034a
pramodcog
reviewed
Jul 30, 2024
| viewer.cameraManager.setCameraState({ position, target }); | ||
|
|
||
| // Check if camera pivot point is in origin |
There was a problem hiding this comment.
Can you add TODO comment here
greenbech
approved these changes
Aug 1, 2024
anders-hopland
deleted the
amh/react-components-reset-camera-preserve-pivot-point
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
BND3D-4470
Description 📝
Preserves the current pivot point when moving the camera to Scene Home position. Currently, when moving the camera to the Scene Home position, the pivot point can be hidden as it's very or in a spot which is not close to the geometry of the model(s). In the future, we should make the Scene store position, rotation and pivot point.
How has this been tested? 🔍
Have been tested in the storybook for SceneContainer
Test instructions ℹ️
Checklist ☑️