Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't consider hidden pointclouds when computing sectors to load and bump to 4.16.1 #4682

Merged
merged 3 commits into from
Jul 26, 2024
Merged

fix: don't consider hidden pointclouds when computing sectors to load and bump to 4.16.1 #4682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fff5b09
fix: don't consider hidden pointclouds when computing sectors to load
haakonflatval-cognite Jul 26, 2024
6df6f89
chore: bump to version 4.16.1
haakonflatval-cognite Jul 26, 2024
2206b07
Merge master into hflatval/dont-load-hidden-pointclouds
cognite-bulldozer[bot] Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion viewer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cognite/reveal",
"version": "4.16.0",
"version": "4.16.1",
"description": "WebGL based 3D viewer for CAD and point clouds processed in Cognite Data Fusion.",
"homepage": "https://github.com/cognitedata/reveal/tree/master/viewer",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion viewer/packages/pointclouds/src/PointCloudManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export class PointCloudManager {
}

updatePointClouds(camera: THREE.PerspectiveCamera): void {
const octrees = this._pointCloudNodes.map(node => node.octree);
const octrees = this._pointCloudNodes.filter(node => node.visible).map(node => node.octree);
this._potreeInstance.updatePointClouds(octrees, camera, this._renderer);
}

Expand Down
Loading