Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): ensure edge connection fetching updates on model change and bump to version 0.54.2 #4679

Merged

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Sometimes, clicking FDM nodes in the model would not result in any sort of coloring, because the query was initiated before all models were added to the scene. This makes sure that the query is re-initialized when the models present in the scene change.

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite changed the title fix(react-components): ensure edge connection fetching updates on model change fix(react-components): ensure edge connection fetching updates on model change and bump to version 0.54.2 Jul 25, 2024
@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) July 25, 2024 12:42
@haakonflatval-cognite haakonflatval-cognite merged commit dd0890d into master Jul 25, 2024
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/activate-edge-fetch-on-model-change branch July 25, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants