Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react-components): factor out Fdm3dDataProvider, in preparations for CoreDM support #4675

Merged
merged 13 commits into from
Jul 26, 2024

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Refactor

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Preliminary preparations for CoreDM. This step involves creating a Fdm3dDataProvider which acts as an abstraction layer between hooks and caches on one side, and the FdmSDK on the other. It implements the logic constructing queries and transforming responses related to 3D in FDM. Currently, only one implementation is made - the LegacyFdm3dDataProvider, which contains all logic specific to the current Fdm contextualization setup (Cdf3dEntity etc.). In a follow-up PR to this, a corresponding CoreDm3dDataProvider will also be implemented.

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite changed the title refactor(react-components): factor out Fdm3dDataProvider, in reparations for CoreDM support refactor(react-components): factor out Fdm3dDataProvider, in preparations for CoreDM support Jul 25, 2024
Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with the review. LGTM. Nice work on refactoring and making it more OOP where it is possible to be while keeping some legacy for now.
Some few comments but nothing problematic.

@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) July 26, 2024 14:50
@haakonflatval-cognite haakonflatval-cognite merged commit 43a84d2 into master Jul 26, 2024
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/coredm-support branch July 26, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants