-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(react-components): factor out Fdm3dDataProvider, in preparations for CoreDM support #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonflatval-cognite
had a problem deploying
to
CI
July 24, 2024 09:07
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
July 24, 2024 09:19
— with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
July 25, 2024 11:39
— with
GitHub Actions
Failure
haakonflatval-cognite
changed the title
refactor(react-components): factor out Fdm3dDataProvider, in reparations for CoreDM support
refactor(react-components): factor out Fdm3dDataProvider, in preparations for CoreDM support
Jul 25, 2024
danpriori
reviewed
Jul 26, 2024
react-components/src/data-providers/legacy-fdm-provider/getCadConnectionsForRevision.ts
Outdated
Show resolved
Hide resolved
danpriori
reviewed
Jul 26, 2024
danpriori
reviewed
Jul 26, 2024
danpriori
reviewed
Jul 26, 2024
danpriori
reviewed
Jul 26, 2024
danpriori
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with the review. LGTM. Nice work on refactoring and making it more OOP where it is possible to be while keeping some legacy for now.
Some few comments but nothing problematic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
Preliminary preparations for CoreDM. This step involves creating a
Fdm3dDataProvider
which acts as an abstraction layer between hooks and caches on one side, and the FdmSDK on the other. It implements the logic constructing queries and transforming responses related to 3D in FDM. Currently, only one implementation is made - theLegacyFdm3dDataProvider
, which contains all logic specific to the current Fdm contextualization setup (Cdf3dEntity etc.). In a follow-up PR to this, a correspondingCoreDm3dDataProvider
will also be implemented.How has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️