Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): Remove fitView when crop the slicing planes + Rename 2 directories #4667

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Jul 17, 2024

  • Rename the directories so they are aligned to the rest (dropping the domainObject suffix)
  • Remove fitView when crop the slicing planes as @haakonflatval-cognite pointed out
  • Remove unnecessary key in LabelWithShortcut (was done inside LabelWithShortcut anywhy)

@nilscognite nilscognite requested a review from a team as a code owner July 17, 2024 08:12
@nilscognite nilscognite changed the title Remove fitView when crop the slicing planes + Rename 2 directories fix(react-components): Remove fitView when crop the slicing planes + Rename 2 directories Jul 17, 2024
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nilscognite nilscognite merged commit 07ea738 into master Jul 17, 2024
14 checks passed
@nilscognite nilscognite deleted the np/cropping-fix branch July 17, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants