-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-components): support node coloring in Reveal3D resources, rename types and bump version 0.53.0 #4665
feat(react-components): support node coloring in Reveal3D resources, rename types and bump version 0.53.0 #4665
Conversation
styling: { | ||
nodeGroups: [ | ||
{ treeIndexSet: new IndexSet([2, 4, 6, 8]), style: { color: new Color('blue') } }, | ||
{ nodeIds: [7152264879809192, 7899489067916664], style: { visible: false } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we allow both node ids and treeindex sets in node groups, or should we encourage the user to transform from nodeids to treeindex sets for usage with low end apis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed support for node IDs 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, still see some node styling groups in the definitions and such, but I am guessing they are used elsewhere
Yes, they are still used internally where we create styling from asset mappings / FDM instances. Btw, I'll bump the react-components version before merging |
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/BND3D-4479
Description 📝
Allow programmers to color CAD-models by node IDs / tree indices
How has this been tested? 🔍
TBA
Test instructions ℹ️
Checklist ☑️