bug: fix unsafe usage of static variables #4664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonflatval-cognite
requested changes
Jul 16, 2024
|
There were failures in the visual tests workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description 📝
TLDR: We're using unsafe static variables to keep state. The issue is that if there are multiple instances of the viewer, then they will end up overwriting each other and we get bugs.
Threads:
https://cognitedata.slack.com/archives/C8A0QGMLN/p1720636595411859
https://cognitedata.slack.com/archives/C8A0QGMLN/p1720612784051089
I guess this would be a breaking change FYI.
How has this been tested? 🔍
Locally nothing breaks. Could use some help with validating this though.
Test instructions ℹ️
Checklist ☑️