refactor: simplify isClipped #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilscognite
requested changes
Jul 13, 2024
| @@ -2,7 +2,7 @@ | |||
| uniform vec4 clippingPlanes[NUM_CLIPPING_PLANES]; | |||
| #endif | |||
|
|
|||
| bool isClipped(NodeAppearance nodeAppearance, vec3 point) { | |||
| bool isClipped(vec3 point) { | |||
| #if NUM_CLIPPING_PLANES > 0 | |||
| vec3 pointFlipped = -point; | |||
| vec4 plane; | |||
There was a problem hiding this comment.
The lines below (in the unchanged code) sucks in my eyes! Why not simplify with early return and remove clipped? Cannot understand why this code has been approved.
There was a problem hiding this comment.
Hehe, not sure why.. It could be that they were afraid that shader threads running in parallel would diverge (one returns early, another one doesn't), which could cause some unfortunate performance loss, but not sure if that's a real concern or not 😅
nilscognite
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
Description 📝
Make use of the general
isClippedmethod in the point cloud rendering too.This was done in an effort to support clipping in 3D overlays, but it seems to crash into some further complications...
How has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️