Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-components): asset search hook to support more than 1000 results #4655

Merged
merged 11 commits into from
Aug 9, 2024
Merged

fix(react-components): asset search hook to support more than 1000 results #4655

merged 11 commits into from
Aug 9, 2024

Conversation

pramodcog
Copy link
Contributor

@pramodcog pramodcog commented Jul 2, 2024 •
edited
Loading

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4459

Description 📝

Existing search hook support 1000 asset as the end point asset.search supports only 1000, in this PR I have changed the way searching of asset work. I have added support for infinite asset search using asset.list utilizing advanced filter option.

How has this been tested? 🔍

In storybook and fusion

Test instructions ℹ️

  • Load SearchHooks storybook example
  • Play around with All asset mappings, Asset search hook and Load more

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@pramodcog pramodcog marked this pull request as ready for review July 5, 2024 11:39
@pramodcog pramodcog requested a review from a team as a code owner July 5, 2024 11:39
haakonflatval-cognite
haakonflatval-cognite previously requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, will spend some time testing after you've had a chance to go through the review 👍

react-components/stories/SearchHooks.stories.tsx Outdated Show resolved Hide resolved
react-components/src/utilities/buildFilter.ts Show resolved Hide resolved
react-components/src/query/useSearchMappedEquipmentAssetMappings.tsx Outdated Show resolved Hide resolved
react-components/src/query/useSearchMappedEquipmentAssetMappings.tsx Outdated Show resolved Hide resolved
react-components/src/query/useSearchMappedEquipmentAssetMappings.tsx Outdated Show resolved Hide resolved
react-components/src/query/useSearchMappedEquipmentAssetMappings.tsx Outdated Show resolved Hide resolved
react-components/src/components/RuleBasedOutputs/RuleBasedOutputsSelector.tsx Outdated Show resolved Hide resolved
danpriori
danpriori approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodcog pramodcog dismissed haakonflatval-cognite’s stale review August 9, 2024 09:12

hakon on vacation and have address his review comments

@pramodcog pramodcog merged commit 7ce38ff into master Aug 9, 2024
14 checks passed
@pramodcog pramodcog deleted the pramodcog/BND3D-4459 branch August 9, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danpriori danpriori danpriori approved these changes

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pramodcog @danpriori @haakonflatval-cognite