Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-components): improve asset mapping cache mechanism and refactoring to stabilize rule threshold styling and switching #4652
fix(react-components): improve asset mapping cache mechanism and refactoring to stabilize rule threshold styling and switching #4652
Changes from 16 commits
7ea39ca
246970f
61d5aa4
71a3dd7
4b848b3
8eb42fa
f46889c
5232873
f7baf3b
5466801
2c1857c
67a8b9d
06309dd
c48d6f6
78673b9
9a5413e
01d9e41
fa47fce
b04a961
6820e25
511c495
06c1f4b
f0282f2
f4f9d23
a123bf9
c46f3cb
818296a
306ca38
2e9ec23
58a592e
fa90456
44c7891
63bf233
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? Could we just use
setCurrentRuleSetEnabled
instead ofsetNewRuleSetEnabled
below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice observation. But this is to let the spinner start render one event cycle before triggering the process of setting the current rule set enabled on the next cycles.
If we set the flag IsRuleLoading on the same event cycle of setting the CurrentRuleSetEnabled, then the spinner will only shows up a bit later in the middle of the rule processing/when the event flow is free to trigger a new render.
Do you have any other suggestion to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can have a comment here 👍