Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): Add NextClippingCommand to the clip tool #4641

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Jun 25, 2024

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4442

Description 📝

This takt the next copping box or slicing planes (all slicing planes is regarded as a group) and use it as clipping.

How has this been tested? 🔍

Open storybook/architecture
Set Crop tool active
Make som boxes and slices
Click at crop
Click at 'Set the next crop box or slicing plane as global clipping' some times.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@nilscognite nilscognite requested a review from a team as a code owner June 25, 2024 08:05
@nilscognite nilscognite changed the title feat(react-components): Add NextClippingCommand command feat(react-components): Add NextClippingCommand to the clip tool Jun 25, 2024
@greenbech
Copy link
Contributor

I think I've found a bug. It's probably easiest to watch the screen recording. It seems like the "Show or hide all other slicing planes and crop boxes" gets into a weird state when you use it together with the next crop box button. Only when you click on the first selected crop box do the other crop boxes show up.

Screen.Recording.2024-06-25.at.14.00.29.mov

@nilscognite
Copy link
Contributor Author

I think I've found a bug. It's probably easiest to watch the screen recording. It seems like the "Show or hide all other slicing planes and crop boxes" gets into a weird state when you use it together with the next crop box button. Only when you click on the first selected crop box do the other crop boxes show up.

Screen.Recording.2024-06-25.at.14.00.29.mov

This is now fixed. I forgot the set them visible(invisible

@nilscognite nilscognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Jun 26, 2024
@nilscognite nilscognite enabled auto-merge (squash) June 26, 2024 05:20
@nilscognite nilscognite enabled auto-merge (squash) June 26, 2024 05:21
@nilscognite nilscognite merged commit 80328b0 into master Jun 26, 2024
14 checks passed
@nilscognite nilscognite deleted the np/crop-box branch June 26, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants