Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(react-components): refactor info panel #4627

Merged
merged 2 commits into from
Jun 20, 2024
Merged

refactor(react-components): refactor info panel #4627

merged 2 commits into from
Jun 20, 2024

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented Jun 20, 2024 •
edited
Loading

Type of change

Refactor

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

A few more refactors to make the code conform slightly more to normal React conventions

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner June 20, 2024 13:55
greenbech
greenbech reviewed Jun 20, 2024
View reviewed changes
react-components/src/components/Architecture/CommandButton.tsx Outdated
<CommandButtonWrapper
command={command}
isHorizontal={isHorizontal}
key={getKey(command, -index)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why -index?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out commands have a numerical key, and it's a running number starting at 1. So chances of collision is pretty high if the index is used as-is

greenbech
greenbech approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@greenbech greenbech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haakonflatval-cognite haakonflatval-cognite merged commit 602c32b into master Jun 20, 2024
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/refactor-architecture-components branch June 20, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenbech greenbech greenbech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haakonflatval-cognite @greenbech