Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (react-components): Add general option and use it to make camera speed settings #4619

Merged
merged 20 commits into from
Jun 24, 2024
Merged

feat (react-components): Add general option and use it to make camera speed settings #4619

merged 20 commits into from
Jun 24, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Jun 19, 2024 •
edited
Loading

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4365

Description 📝

  • Generalize possibility to add option to the general toolbar. Any thing that can have a icon or sytring can be a part of the options.
  • Use it to make a SetSpeedOptionCommand, which sets the speed of the camera keyboard.

How has this been tested? 🔍

Use storybook, architecture:. You se the option there.

@nilscognite nilscognite requested a review from a team as a code owner June 19, 2024 14:15
danpriori
danpriori requested changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but the rest looks good!

@nilscognite
Copy link
Contributor Author

The fixes are here: 836d8d5

@nilscognite nilscognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Jun 24, 2024
@nilscognite nilscognite enabled auto-merge (squash) June 24, 2024 13:14
danpriori
danpriori approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Nice work man!
LGTM

@nilscognite nilscognite merged commit 25d1ec4 into master Jun 24, 2024
23 checks passed
@nilscognite nilscognite deleted the np/option-menues branch June 24, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danpriori danpriori danpriori approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilscognite @danpriori