Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make options for FlexibleControls available outside Reveal + Add speed option #4618

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

nilscognite
Copy link
Contributor

Type of change

Feat

Description 📝

  • Expose the options out of Reveal
  • Made a new speed option. Default this is 0

How has this been tested? 🔍

Can not test this yet. Another PR in components

@nilscognite nilscognite requested a review from a team as a code owner June 19, 2024 13:58
@nilscognite nilscognite changed the title (feat): Make options available feat: Make options available Jun 19, 2024
@nilscognite nilscognite changed the title feat: Make options available feat: Make options for FlexibleControls available outside Reveal + Ann speed option Jun 19, 2024
@nilscognite nilscognite changed the title feat: Make options for FlexibleControls available outside Reveal + Ann speed option feat: Make options for FlexibleControls available outside Reveal + Add speed option Jun 19, 2024
Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment.
I think it is good if the "shift" is intentional and we can approve. Otherwise I think we have to change it.

@nilscognite nilscognite enabled auto-merge (squash) June 19, 2024 19:14
@nilscognite nilscognite enabled auto-merge (squash) June 19, 2024 19:14
@nilscognite nilscognite merged commit 2c9fa9d into master Jun 19, 2024
14 checks passed
@nilscognite nilscognite deleted the np/camera-speed branch June 19, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants