Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (react-components): Use primary button for cropping and do not show measurements completely outside the bounding box #4611

Merged
merged 1 commit into from
Jun 18, 2024
Merged

feat (react-components): Use primary button for cropping and do not show measurements completely outside the bounding box #4611

merged 1 commit into from
Jun 18, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Jun 18, 2024 •
edited
Loading

Type of change

Feat

Jira ticket 📘

Description 📝

  • If using clipping, do not show measurements that do not overlap with the clip box
  • Use primary to toggle on or off the cropping, since this is the most important in the toolbar

image
image

@nilscognite nilscognite requested a review from a team as a code owner June 18, 2024 08:43
@nilscognite nilscognite changed the title react-components (feat): Use primary button for cropping and do not show measurements completely outside the bounding box (feat) react-components: Use primary button for cropping and do not show measurements completely outside the bounding box Jun 18, 2024
@nilscognite nilscognite changed the title (feat) react-components: Use primary button for cropping and do not show measurements completely outside the bounding box feat (react-components): Use primary button for cropping and do not show measurements completely outside the bounding box Jun 18, 2024
@nilscognite nilscognite merged commit 341a5d2 into master Jun 18, 2024
14 checks passed
@nilscognite nilscognite deleted the np/box-gizmo branch June 18, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilscognite @haakonflatval-cognite