Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
In order to use
Overlay3DCollection
s as aDomainObject
in react-components, it must be exported explicitly, since it is currently being added into the scene and managed that way directly by theOverlay3DTool
with no way to interfere.Point still up for discussion: Should the Overlay3DCollection only be constructible from Overlay3DTool? The constructor is currently a little ugly (needs access to the viewer's camera manager).
The refactoring in this PR involves moving the intersection logic into Overlay3DCollection, making it usable from the outside. (In my opinion, this should have been done earlier anyway).
How has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️