Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-component(feat): Add crop box, slicing and tool, generalize box concept #4594

Merged
merged 43 commits into from
Jun 17, 2024
Merged

react-component(feat): Add crop box, slicing and tool, generalize box concept #4594

merged 43 commits into from
Jun 17, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Jun 12, 2024 •
edited
Loading

Type of change

Feat

Description 📝

  • Move all general box and line to own folder called primitives
  • For measurements use classes in primitives as base classes
  • For crop box use classes in primitives as base classes
  • New domain object, plane, also in primitives
  • Made crop box and slicer plane functionality quite finished.
  • Done some minor changes in the architecture and fixed a few bugs in the base classes or made them even for flexible.

To test it:

  1. Use storybook, architecture folder
  2. Click on the crop icon
  3. You will get a toolbar with some tool to experiment with. Read the tooltip. The planes can be created, moved and deleted. Same with the crop box. If the crop box is selected, and applied crop is click, then it will use the plane for this. Otherwise, the planes will be for the slicing planes you have made.

@nilscognite nilscognite requested a review from a team as a code owner June 12, 2024 07:06
@nilscognite nilscognite marked this pull request as draft June 12, 2024 08:24
@greenbech
Copy link
Contributor

Currently right-clicking on the crop box acts the same as left clicking. I expect right clicking to pan the camera, not interact with the crop box

haakonflatval-cognite
haakonflatval-cognite approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

react-components/src/architecture/base/commands/BaseCommand.ts Outdated Show resolved Hide resolved
react-components/src/architecture/base/commands/InstanceCommand.ts Outdated Show resolved Hide resolved
react-components/src/architecture/base/utilities/extensions/vectorExtensions.ts Outdated Show resolved Hide resolved
react-components/src/architecture/concrete/clipping/ClipTool.ts Show resolved Hide resolved
react-components/src/architecture/concrete/measurements/commands/SetMeasurementTypeCommand.ts Show resolved Hide resolved
react-components/src/architecture/concrete/measurements/getIconByPrimitiveType.ts Show resolved Hide resolved
react-components/src/architecture/base/renderStyles/DepthTestRenderStyle.ts Outdated Show resolved Hide resolved
@nilscognite nilscognite enabled auto-merge (squash) June 17, 2024 20:14
@nilscognite nilscognite merged commit 14f2d90 into master Jun 17, 2024
14 checks passed
@nilscognite nilscognite deleted the np/crop-box branch June 17, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilscognite @greenbech @haakonflatval-cognite