Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): don't remove models automatically on switching viewer #4589

Merged

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4283

Description 📝

This fixes a bug where models would be removed regardless of the new scene content when switching viewer, effectively bypassing the RevealKeepAlive-concept. This is fixed by making sure not to leave the model add data undefined while getting model types.

How has this been tested? 🔍

Test instructions ℹ️

In Search, click a 3D asset, then Open to go to its instance page. On the 3D widget, click expand. Note that the model is not re-loaded when entering the expanded widget.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner June 10, 2024 14:49
@haakonflatval-cognite haakonflatval-cognite changed the title fix(react-components): don't remove models automatically on switching… fix(react-components): don't remove models automatically on switching viewer Jun 10, 2024
@haakonflatval-cognite
Copy link
Contributor Author

TODO: Refactor tests so that fixtures can be reused

@haakonflatval-cognite
Copy link
Contributor Author

Done adding tests 👍

@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) June 11, 2024 06:54
@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Jun 11, 2024
@haakonflatval-cognite haakonflatval-cognite merged commit a4d82c7 into master Jun 11, 2024
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/persist-models-on-viewer-switch branch June 11, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants