fix(react-components): don't remove models automatically on switching viewer #4589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/BND3D-4283
Description 📝
This fixes a bug where models would be removed regardless of the new scene content when switching viewer, effectively bypassing the RevealKeepAlive-concept. This is fixed by making sure not to leave the model add data undefined while getting model types.
How has this been tested? 🔍
Test instructions ℹ️
In Search, click a 3D asset, then Open to go to its instance page. On the 3D widget, click expand. Note that the model is not re-loaded when entering the expanded widget.
Checklist ☑️