Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor (react-components): Used latest changes in Reveal (OnWheel, movement of Vector3Pool) + Final touch on the course material #4586

Merged
merged 10 commits into from
Jun 10, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Jun 10, 2024

Type of change

Refactor <!-- refactoring production code, eg. renaming a variable -
https://cognitedata.atlassian.net/browse/

Description 📝

  • Fix typos
  • Some renaming
  • Made example code better
  • Updated the example/readme file
  • Remove Vector3Pool and used the one in Reveal
  • Updated the onWheel signatur

@nilscognite nilscognite requested a review from a team as a code owner June 10, 2024 10:22
@nilscognite nilscognite changed the title refactor: Used latest changes in Reveal (OnWheel, movment of Vector3Pool) + Final touch on the course material refactor: Used latest changes in Reveal (OnWheel, movement of Vector3Pool) + Final touch on the course material Jun 10, 2024
@nilscognite nilscognite changed the title refactor: Used latest changes in Reveal (OnWheel, movement of Vector3Pool) + Final touch on the course material refactor (react-components): Used latest changes in Reveal (OnWheel, movement of Vector3Pool) + Final touch on the course material Jun 10, 2024
@nilscognite nilscognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Jun 10, 2024
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 But I'd like to have the comment I made addressed

Comment on lines 9 to 10
CanNotBeVisibleNow, // Can not be checked on, but it can be visible
Disabled // Visible disabled
Disabled // Visible disabled, not objects can be visible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names and comments of these two items were rather confusing 😅

@nilscognite nilscognite merged commit 51c661b into master Jun 10, 2024
14 checks passed
@nilscognite nilscognite deleted the np/use-latest-reveal branch June 10, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants