Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use Vector3Pool instead of ReusableVector3s and extra argument to IFlexibleCameraManager .onWheel #4585

Merged
merged 7 commits into from
Jun 10, 2024
Merged

refactor: Use Vector3Pool instead of ReusableVector3s and extra argument to IFlexibleCameraManager .onWheel #4585

merged 7 commits into from
Jun 10, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Jun 10, 2024 •
edited
Loading

Type of change

Refactor

Description 📝

  • The class Vector3Pool is moved from react-components
  • Removed ReusableVector3s
  • Use Vector3Pool instead of ReusableVector3s
  • Expose Vector3Pool out of Reveal. Change a little bit on the usage.
  • Expose getWheelEventDelta
  • Updated onWheel in IFlexibleCameraManager to have an extra argument. The reason for this is to synchronize what delta means, since it may depend of the browser. I then calculated it once and used everywhere.

@nilscognite nilscognite requested a review from a team as a code owner June 10, 2024 06:12
@nilscognite nilscognite changed the title (refactor) (refactor) Use Vector3Pool instead of ReusableVector3s and extra argument to IFlexibleCameraManager .onWheel Jun 10, 2024
@nilscognite nilscognite enabled auto-merge (squash) June 10, 2024 06:28
@nilscognite nilscognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Jun 10, 2024
haakonflatval-cognite
haakonflatval-cognite approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nilscognite nilscognite changed the title (refactor) Use Vector3Pool instead of ReusableVector3s and extra argument to IFlexibleCameraManager .onWheel refactor: Use Vector3Pool instead of ReusableVector3s and extra argument to IFlexibleCameraManager .onWheel Jun 10, 2024
@nilscognite nilscognite merged commit a59e93d into master Jun 10, 2024
14 checks passed
@nilscognite nilscognite deleted the np/reveal-fixes branch June 10, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilscognite @haakonflatval-cognite