Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) react-component: Working on example code and the course #4575

Merged
merged 10 commits into from
Jun 10, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Jun 5, 2024

Type of change

Feat

Description:

  • Corrected all types using spell checker extension, in filenames, comments and names in general (a lot of files)
  • Updated some comments
  • Add buttonType to BaseCommand and use it in the react code
  • Added some convenience methods in the BaseEditTool
  • Updated DomainObjectChange to more flexible
  • Add the command ShowExamplesOnTopCommand for the example code
  • Remove the old toolbar in the architecture story
  • Finished the README.md for the course

@nilscognite nilscognite requested a review from a team as a code owner June 5, 2024 11:45
@nilscognite nilscognite marked this pull request as draft June 5, 2024 11:45
@haakonflatval-cognite
Copy link
Contributor

Title should be feat(react-components): ...

@nilscognite nilscognite changed the title react-component (feat) Working on example code react-component (feat) Working on example code and the course Jun 9, 2024
@nilscognite nilscognite marked this pull request as ready for review June 9, 2024 19:03
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment on lines +70 to +74
// This was the only way it went through compiler: (more bytton types will be added in the future)
const type = newCommand.buttonType;
if (type !== 'ghost' && type !== 'ghost-destructive') {
return <></>;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - what kind of error do you get when you don't have this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to cast, but ButtonType/GhostButtonType is not exposed. It has to be a ButtonType or a GhostButtonType. The syntax i cogs is really hard to understand.

@nilscognite nilscognite changed the title react-component (feat) Working on example code and the course (feat) react-component: Working on example code and the course Jun 10, 2024
@nilscognite nilscognite enabled auto-merge (squash) June 10, 2024 06:57
@nilscognite nilscognite merged commit 509ca8c into master Jun 10, 2024
14 checks passed
@nilscognite nilscognite deleted the np/example branch June 10, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants