-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-components): let user control 360 icon culling options #4559
feat(react-components): let user control 360 icon culling options #4559
Conversation
cullingParameters?.radius ?? Infinity, | ||
cullingParameters?.iconCountLimit ?? 50 | ||
); | ||
}, [collection, cullingParameters?.radius, cullingParameters?.iconCountLimit]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useEffect
will get trigger every time cullingParameters
object changes even if cullingParameters.radius
& cullingParameters.iconCountLimit
is not changed
react-components/src/components/Image360CollectionContainer/Image360CollectionContainer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a comment, including the Pramod's suggestion, and you are good to go I think.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
Expose a way for users to control the 360 icon culling parameters - max radius for 360 visualization, and max amount of 360 icons
How has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️