Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): incorrect label string for 360 Image in Layers filter and Split window header UI for long string #4555

Merged
merged 3 commits into from
May 30, 2024

Conversation

pramodcog
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4292
https://cognitedata.atlassian.net/browse/BND3D-4287

Description 📝

360 Image label in Layers filter was displaying site-id/external-id and when long string is passed to Split window, UI alignment would cause window to expand the header. This PR fixes the issue

360 Issue
image (1)
Fix
Screenshot 2024-05-30 at 14 32 10

Split Window issue
image
Fix
Screenshot 2024-05-30 at 14 24 20

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@pramodcog pramodcog requested a review from a team as a code owner May 30, 2024 12:34
@pramodcog pramodcog added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label May 30, 2024
Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodcog pramodcog merged commit 77c1cc6 into master May 30, 2024
23 checks passed
@pramodcog pramodcog deleted the pramodcog/BND3D-4292 branch May 30, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants