Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Some renaming, and smaller fixes #4548

Merged
merged 55 commits into from
May 30, 2024
Merged

(feat) Some renaming, and smaller fixes #4548

merged 55 commits into from
May 30, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented May 28, 2024 •
edited
Loading

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

  • Made the font smaller in the Panel
  • Use the toolbar layout to set the toolbar at right position.
  • Make CommandsUpdater where updates in OnIdle. This will force the updating of the commands will happen only one time for each user interaction (click a button, delete or add an object, set object selected or visible)
  • Rename toolsController -> commandsController since it also store all commands (better naming)
  • Some other ranaming
  • Adding experimental crop box functionality, but not the UI for it
  • Just made the example code even better

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

nilscognite and others added 30 commits May 25, 2024 11:33
@nilscognite
Initial commit
d21937d
@nilscognite
Some movements
9ac6395
@nilscognite
Fix linter problems
0c69ba7
@nilscognite
Make the axis a tiny better
53499d6
@nilscognite
Comments only
648d916
@nilscognite
Some rafactoring
c23aa7d
@nilscognite
Make it better
e0bed21
@nilscognite
Update MeasurementTool.ts
39f5ae6
@nilscognite
Fix lint
89243a8
@nilscognite
Make better axis tick labels, but still not perfect
1f05ec0
@nilscognite
handleEscape better
3f8ed41
@nilscognite
Changes in RevealRenderTarget
bc61459
@nilscognite
Update RootDomainObject.ts
7d0b716
@nilscognite
Fix smal bug
96f9bd1
@nilscognite
Moving code
2a4de0a
@nilscognite
Merge branch 'master' into np/architecture-continued
7826f7c
@nilscognite
Fix typo
a580f55
@nilscognite
Set new default value
7570059
@nilscognite
Fix typo
0f91bd0
@nilscognite
Merge branch 'master' into np/example-code
ad31e2d
@nilscognite
Merge branch 'master' into np/example-code
7f4ee11
@nilscognite
Initial commit
ad63029
@nilscognite
Update Architecture.stories.tsx
f2748f2
@nilscognite
Update yarn.lock
98d8406
@nilscognite
Fix MeasureLineView so lines are visible from long distance
316fd10
@nilscognite
Make a DefaultRevealConfig
d42f04c
@nilscognite
Add override keyword
d4804cc
@nilscognite
Remove some unneccesary code
b5bcab4
@nilscognite
Merge branch 'master' into np/architecture-continued
0b55801
@nilscognite
Merge branch 'master' into np/example-code
92fa70e
@nilscognite nilscognite changed the title (feat) Crop box (feat) Some renaming, and smaller fixes May 29, 2024
@nilscognite nilscognite marked this pull request as ready for review May 30, 2024 09:01
pramodcog
pramodcog reviewed May 30, 2024
View reviewed changes
react-components/src/architecture/base/reactUpdaters/CommandsUpdater.ts
if (this._idleCallbackId < 0) {
return;
}
window.cancelIdleCallback(this._idleCallbackId);
Copy link
Contributor

@pramodcog pramodcog May 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing renderTarget assignment to undefined in dispose which can cause a memory leak

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See f7be729

pramodcog
pramodcog approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@nilscognite nilscognite enabled auto-merge (squash) May 30, 2024 12:26
@nilscognite nilscognite merged commit 0531899 into master May 30, 2024
14 checks passed
@nilscognite nilscognite deleted the np/crop-box branch May 30, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodcog pramodcog pramodcog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilscognite @pramodcog