Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Make example code for training and some changes in the architecture #4543

Merged
merged 34 commits into from
May 28, 2024
Merged

(feat) Make example code for training and some changes in the architecture #4543

merged 34 commits into from
May 28, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented May 28, 2024 •
edited
Loading

Type of change

Feat

https://cognitedata.atlassian.net/browse/

Description 📝

  • Example code for showing how the architecture is working (Please do not review this)
  • Some minor changes in the architecture code
  • Made the main toolbar generic
  • Made the CogniteRenderTarget configurative with BaseRevealConfig that can be overridden. This is set by setConfig
  • Fix MeasureLineView so lines are visible from long distance

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@nilscognite nilscognite requested a review from a team as a code owner May 28, 2024 10:09
haakonflatval-cognite
haakonflatval-cognite reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having some trouble with the line width being 1 pixel no matter what we set it to.

react-components/src/architecture/base/domainObjectsHelpers/BaseDragger.ts Show resolved Hide resolved
react-components/stories/Architecture.stories.tsx Outdated Show resolved Hide resolved
haakonflatval-cognite
haakonflatval-cognite approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 But please fix the issues I've mentioned

@nilscognite @haakonflatval-cognite
Update react-components/stories/Architecture.stories.tsx
7fcbcc6 
Co-authored-by: Håkon Flatval <70905152+haakonflatval-cognite@users.noreply.github.com>
@nilscognite nilscognite merged commit b639f68 into master May 28, 2024
14 checks passed
@nilscognite nilscognite deleted the np/architecture-continued branch May 28, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilscognite @haakonflatval-cognite