-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: styling for 360 icons #3757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3757 +/- ##
==========================================
- Coverage 71.70% 71.61% -0.10%
==========================================
Files 346 346
Lines 33798 33847 +49
Branches 2652 2653 +1
==========================================
+ Hits 24236 24238 +2
- Misses 9454 9501 +47
Partials 108 108
|
christjt
requested changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Can you add some color to one of the icons we have in the visual test?
christjt
approved these changes
Oct 3, 2023
haakonflatval-cognite
added
the
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
label
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/UX-1560
Description 📝
Support styling of 360 icons. Especially interesting for indicating presence of annotations in the 360 image.
Currently does not play particularily well with the icon octree. Task to mitigate this is kept here: https://cognitedata.atlassian.net/browse/REV-994
How has this been tested? 🔍
In examples - in
Image360Ui
, adding colors to loaded entities when adding a new image collection.Test instructions ℹ️
Checklist ☑️