Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: styling for 360 icons #3757

Merged
merged 14 commits into from
Oct 3, 2023
Merged

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented Sep 29, 2023

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/UX-1560

Description 📝

Support styling of 360 icons. Especially interesting for indicating presence of annotations in the 360 image.

Currently does not play particularily well with the icon octree. Task to mitigate this is kept here: https://cognitedata.atlassian.net/browse/REV-994

How has this been tested? 🔍

In examples - in Image360Ui, adding colors to loaded entities when adding a new image collection.

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner September 29, 2023 13:04
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #3757 (8c3da94) into master (298253f) will decrease coverage by 0.10%.
The diff coverage is 41.66%.

@@            Coverage Diff             @@
##           master    #3757      +/-   ##
==========================================
- Coverage   71.70%   71.61%   -0.10%     
==========================================
  Files         346      346              
  Lines       33798    33847      +49     
  Branches     2652     2653       +1     
==========================================
+ Hits        24236    24238       +2     
- Misses       9454     9501      +47     
  Partials      108      108              
Files Coverage Δ
viewer/packages/360-images/index.ts 100.00% <100.00%> (ø)
...r/packages/360-images/src/entity/Image360Entity.ts 76.70% <100.00%> (+1.85%) ⬆️
viewer/packages/3d-overlays/src/Overlay3DIcon.ts 57.96% <100.00%> (+3.41%) ⬆️
viewer/api-entry-points/core.ts 0.00% <0.00%> (ø)
...er/packages/360-images/src/icons/IconCollection.ts 70.64% <16.66%> (-1.23%) ⬇️
viewer/packages/360-images/src/entity/Image360.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@christjt christjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can you add some color to one of the icons we have in the visual test?

viewer/packages/3d-overlays/src/Overlay3DIcon.ts Outdated Show resolved Hide resolved
@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Oct 3, 2023
@haakonflatval-cognite haakonflatval-cognite merged commit 39b9b80 into master Oct 3, 2023
15 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/360-icon-styling branch October 3, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants