Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): optimize styled node collection diff check on re-render #3753

Merged
merged 8 commits into from
Sep 28, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented Sep 27, 2023

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Optimize style-difference check. This severely hampered performance on model

{
    modelId: 3282558010084460,
    revisionId: 4932190516335812
}

in 3d-test. This is likely due to the large number of mapped equipment.

Essentially, this optimization ensures index sets are not reconstructed unnecessarily, but stored properly from when edges are constructed.

Update: It seems like I (using Firefox on Linux) am the only one having these severe performance problems. I'm adding a video to document what the experience is at my end:

slow_click.mp4

How has this been tested? 🔍

In FDX locally.

Test instructions ℹ️

Open https://apps.cognite.com/explore/FDX_Boys/fdx-boys/2/Equipment/fdx-boys/Gokhan-2878543855731702-IAA?aiSearch=false&viewMode=3d and notice how clicks on Ivar Aasen (the oil platform) are sort-of slow.

Use this PR in FDX locally, and see how clicks are notably faster.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner September 27, 2023 13:06
@haakonflatval-cognite haakonflatval-cognite changed the title fix: optimize styled node collection diff check on re-render fix(react-components): optimize styled node collection diff check on re-render Sep 27, 2023
@haakonflatval-cognite haakonflatval-cognite added the slack PRs and issues with this label will be pushed to Slack label Sep 27, 2023
christjt
christjt previously approved these changes Sep 27, 2023
@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Sep 27, 2023
@haakonflatval-cognite haakonflatval-cognite merged commit 10c78b4 into master Sep 28, 2023
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/optimize-rerender-style-check branch September 28, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants