Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate react components from babel / webpack to vite #3728

Merged
merged 19 commits into from
Sep 25, 2023

Conversation

christjt
Copy link
Contributor

@christjt christjt commented Sep 22, 2023

Type of change

Chore

Description 📝

How has this been tested? 🔍

Manually tested build output in FDX, manually tested storybook. Also compared build output bundle size to make sure there are no regressions.

Test instructions ℹ️

  • Building still works
  • Storybook still works (with hot module reload)
  • There are no performance regressions when building the package or serving storybook
  • Running the command yarn run build:watch:yalc and yarn link ... in FDX properly sets up a flow where changes in react components are automatically propagated to FDX without any additional commands needed

NOTE ON LAST POINT: linking this package into FDX will have some issues since yarn in FDX will not respect new dependencies in reveal react components. So for this test you will need to yalc add -> yarn install in FDX then yalc link. This awkward step will not be nessesary once the actual npm package published has been updated in FDX. This is not a regression and was how it worked previously as well, it is simply noticable now in this PR since I had to change some deps.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@christjt christjt added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Sep 22, 2023
@christjt christjt requested a review from a team as a code owner September 22, 2023 15:01
@christjt christjt force-pushed the christjt/react-components-vite-migration branch from 69abc32 to 7d18f6e Compare September 22, 2023 15:48
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels really good! Very decent upgrade in terms of build speed and especially linking with FDX works really smooth!

@christjt christjt merged commit d42f205 into master Sep 25, 2023
14 checks passed
@christjt christjt deleted the christjt/react-components-vite-migration branch September 25, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants