Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-components): translation config updated to enable FDX to append translation from react-component #3675

Merged
merged 4 commits into from
Sep 6, 2023
Merged

fix(react-components): translation config updated to enable FDX to append translation from react-component #3675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
484b0d0
updated translation according to FDX config so as to overcome I18nWra…
pramodcog Sep 5, 2023
613dc4c
Merge refs/heads/master into pramodcog/update-translation-as-append-t…
cognite-bulldozer[bot] Sep 6, 2023
9c974a5
Merge refs/heads/master into pramodcog/update-translation-as-append-t…
cognite-bulldozer[bot] Sep 6, 2023
32cc0e9
Merge refs/heads/master into pramodcog/update-translation-as-append-t…
cognite-bulldozer[bot] Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion react-components/src/common/i18n/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ export const translations = {
export type TranslationKeys = keyof typeof en;

export const useTranslation = (): ReturnType<typeof useTypedTranslation<TranslationKeys>> =>
useTypedTranslation<TranslationKeys>();
useTypedTranslation<TranslationKeys>('reveal-react-components');
2 changes: 1 addition & 1 deletion react-components/src/components/RevealToolbar/RevealToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const RevealToolbarContainer = (
props = { ...props, ...defaultStyle };
}
return (
<I18nWrapper translations={translations} defaultNamespace="reveal-react-components">
<I18nWrapper translations={translations} addNamespace="reveal-react-components">
<ToolBar {...props}>{props.toolBarContent ?? <DefaultContentWrapper {...props} />}</ToolBar>
</I18nWrapper>
);
Expand Down
Loading