Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: bump documentation sidebar to 4.x #3668

Merged
merged 6 commits into from
Sep 5, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Docs

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Copy next-release's documentation sidebar into sidebar 4.x.

Most notably, this includes the image 360 annotation section into the sidebar.

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite added slack PRs and issues with this label will be pushed to Slack preview-docs Deploy preview documentation for a PR labels Sep 4, 2023
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner September 4, 2023 13:56
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #3668 (be8d753) into master (4c59d22) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3668   +/-   ##
=======================================
  Coverage   71.70%   71.70%           
=======================================
  Files         346      346           
  Lines       33739    33739           
  Branches     2649     2649           
=======================================
  Hits        24192    24192           
  Misses       9440     9440           
  Partials      107      107           

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/3668/docs/next/.

christjt
christjt previously approved these changes Sep 4, 2023
@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Sep 4, 2023
@haakonflatval-cognite haakonflatval-cognite merged commit 27bf5a9 into master Sep 5, 2023
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/bump-version-sidebar-4.x branch September 5, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch preview-docs Deploy preview documentation for a PR slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants