Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-components): add fetching of the view for mapped equipment hook #3654

Merged
merged 33 commits into from
Sep 5, 2023
Merged

feat(react-components): add fetching of the view for mapped equipment hook #3654

merged 33 commits into from
Sep 5, 2023

Conversation

Savokr
Copy link
Contributor

@Savokr Savokr commented Aug 30, 2023 •
edited
Loading

Type of change

Feat

Jira ticket 📘

Related to 3D search panel in FDX.

Description 📝

In order to display 3D mapped only data in search panel in FDX app the hook for getting mapped equipment is required to supply view of corresponding equipment. This PR adds this capability together with small fixes like supporting pagination for instance inspection query and using cache for camera navigation hook.

How has this been tested? 🔍

In HighlightNode story

Test instructions ℹ️

Go to HighlightNode story and observe that everything is styled in a correct way and with decent performance.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@Savokr Savokr added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Aug 30, 2023
@Savokr Savokr requested a review from a team as a code owner August 30, 2023 16:37
haakonflatval-cognite
haakonflatval-cognite requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've included some suggestions

react-components/src/components/NodeCacheProvider/FdmNodeCache.ts Outdated Show resolved Hide resolved
react-components/src/components/NodeCacheProvider/NodeCacheProvider.tsx Show resolved Hide resolved
react-components/src/components/NodeCacheProvider/requests.ts Show resolved Hide resolved
react-components/src/components/NodeCacheProvider/types.ts Show resolved Hide resolved
react-components/src/components/NodeCacheProvider/RevisionFdmNodeCache.ts Outdated Show resolved Hide resolved
cognite-bulldozer bot and others added 18 commits August 31, 2023 15:15
@cognite-bulldozer
Merge refs/heads/master into savokr/add-view-fetching-for-mapped-nodes
d4fa06a
@cognite-bulldozer
Merge refs/heads/master into savokr/add-view-fetching-for-mapped-nodes
0434004
@cognite-bulldozer
Merge refs/heads/master into savokr/add-view-fetching-for-mapped-nodes
2efbca5
@cognite-bulldozer
Merge refs/heads/master into savokr/add-view-fetching-for-mapped-nodes
e0b7a3f
@Savokr
Minor PR fixes
8c687b0
@Savokr
Merge branch 'master' into savokr/add-view-fetching-for-mapped-nodes
2a9783a
@Savokr
Fixed nodeId type issue
8d0a905
@Savokr
Merge branch 'savokr/add-view-fetching-for-mapped-nodes' of https://g…
defc72b 
…ithub.com/cognitedata/reveal into savokr/add-view-fetching-for-mapped-nodes
@cognite-bulldozer
Merge master into savokr/add-view-fetching-for-mapped-nodes
82b1427
@cognite-bulldozer
Merge refs/heads/master into savokr/add-view-fetching-for-mapped-nodes
f62e415
@cognite-bulldozer
Merge refs/heads/master into savokr/add-view-fetching-for-mapped-nodes
ad29158
@cognite-bulldozer
Merge refs/heads/master into savokr/add-view-fetching-for-mapped-nodes
c691385
@cognite-bulldozer
Merge refs/heads/master into savokr/add-view-fetching-for-mapped-nodes
ad8486b
@cognite-bulldozer
Merge refs/heads/master into savokr/add-view-fetching-for-mapped-nodes
a2e365e
@cognite-bulldozer
Merge refs/heads/master into savokr/add-view-fetching-for-mapped-nodes
164b395
@cognite-bulldozer
Merge refs/heads/master into savokr/add-view-fetching-for-mapped-nodes
200cd90
@Savokr
New hook added
ab2d1dc
@Savokr
Missing hook file
63c996c
haakonflatval-cognite
haakonflatval-cognite previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small nitpicks, looks good now! 👍

react-components/src/hooks/useCameraNavigation.tsx Show resolved Hide resolved
react-components/src/hooks/useClickedNode.tsx Show resolved Hide resolved
react-components/src/hooks/use3dNodeByExternalId.tsx Outdated Show resolved Hide resolved
@Savokr Savokr enabled auto-merge (squash) September 5, 2023 08:23
@Savokr Savokr merged commit e1d8aa4 into master Sep 5, 2023
14 checks passed
@Savokr Savokr deleted the savokr/add-view-fetching-for-mapped-nodes branch September 5, 2023 08:24
@Savokr Savokr mentioned this pull request Sep 8, 2023
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Savokr @haakonflatval-cognite